Burathar
/
The-Hunt
1
0
Fork 0
Code Issues 24 Pull Requests Releases Wiki Activity
Labels Milestones
New Issue

Move relations from Player to Game_Player #22

Closed
opened 5 years ago by Burathar · 2 comments
Burathar commented 5 years ago
Owner

At this moment, Player_Caught_Player, Player_Found_Player, and Notification_Player have relations with the Player table. However, the actions that these tables represent (Notifying, catching, and finding) all happen within the context of a game. Therefore, these relations should point at Game_Player, istead of Player.

At this moment, Player_Caught_Player, Player_Found_Player, and Notification_Player have relations with the Player table. However, the actions that these tables represent (Notifying, catching, and finding) all happen within the context of a game. Therefore, these relations should point at Game_Player, istead of Player.
Burathar added this to the Release 1.0 milestone 5 years ago
Burathar added the
bug
enhancement-must
 labels 5 years ago
Burathar self-assigned this 5 years ago
Burathar commented 5 years ago
Poster
Owner

Changes:

  • Player table renamed to User

  • Add Id to Game_Player

  • Replace PlayerId in Notification_Player with Game_Player_Id

  • Replace PlayerId in Player_Found_Objective with Game_Player_Id

  • Replace CatchingPlayerId in Player_Caught_Player with Game_Player_Id

  • Replace CaughtPlayerId in Player_Caught_Player with Game_Player_Id

  • Make clear in diagram that Game_Player Role defaults (to Role.none)

The names of the associationtables were not changed, because for instance Notification_Game_Player could be confused for a theeway association between Notigication, Game, and Player. Furthermore, The Player table is renamed to User, so Player only references Game_Player

Changes: * `Player` table renamed to `User` * Add Id to `Game_Player` * Replace `PlayerId` in `Notification_Player` with `Game_Player_Id` * Replace `PlayerId` in `Player_Found_Objective` with `Game_Player_Id` * Replace `CatchingPlayerId` in `Player_Caught_Player` with `Game_Player_Id` * Replace `CaughtPlayerId` in `Player_Caught_Player` with `Game_Player_Id` * Make clear in diagram that `Game_Player` `Role` defaults (to Role.none) The names of the associationtables were not changed, because for instance `Notification_Game_Player` could be confused for a theeway association between Notigication, Game, and Player. Furthermore, The Player table is renamed to User, so Player only references Game_Player
Burathar commented 5 years ago
Poster
Owner

Solved in commit b57d91d37c

Solved in commit b57d91d37c
Burathar closed this issue 5 years ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
QR-seachgame
feature_tests
master
testing
Labels
Apply labels
Clear labels
bug
Something is not working duplicate
This issue or pull request already exists enhancement-must
New feature enhancement-should
Non-critical new feature help wanted
Need some help invalid
Something is wrong question
More information is needed security enhancement
New feature/adjustment to improve security wontfix
This won't be fixed
No Label bug duplicate enhancement-must enhancement-should help wanted invalid question security enhancement wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Release 1.0
Assignees
Assign users
Clear assignees
No Assignees
Burathar
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes